Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C implementation: Fix compiler warnings #666

Open
fulldecent opened this issue Dec 23, 2024 · 3 comments
Open

C implementation: Fix compiler warnings #666

fulldecent opened this issue Dec 23, 2024 · 3 comments

Comments

@fulldecent
Copy link
Contributor

The C implementation currently has compiler warnings.

https://github.com/google/open-location-code/actions/runs/12468691641/job/34800362797

These are related to non-standard extensions implemented in our C implementation instead of what our specification requires.
@fulldecent
Copy link
Contributor Author

Fixed at #651

That PR

  • Fixes C build warnings from code issue
  • Fixes C build warnings from Bazel issues

and results in no C build warnings

@fulldecent fulldecent mentioned this issue Dec 23, 2024
Open
@drinckes
Copy link
Contributor

What are the warnings you want to address? Is it just?

warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]

@fulldecent
Copy link
Contributor Author

I wanted it to build clean with no warnings or errors as reported in GitHub actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fulldecent @drinckes