Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPP implementation: does not reference a required separator character #443

Open
fulldecent opened this issue Apr 25, 2021 · 2 comments
Open
Labels

Comments

@fulldecent
Copy link
Contributor

The C++ implementation states:

// Returns an Open Location Code with code_length significant digits. The string
// returned may be one character longer if it includes a separator character
// for formatting.

This is underspecified. Every plus code will have a separator character. CITATION NEEDED. Therefore a better wording would be to say:

// Returns an Open Location Code with code_length significant digits. The string
// returned will be one character longer because it includes a separator character
// for formatting.

@fulldecent
Copy link
Contributor Author

fulldecent commented Apr 25, 2021

Recommended tag: implementation

@fulldecent
Copy link
Contributor Author

I realize this wording is CPP is based on a older and outdated understanding of OLC that used to be here. So this is issue should still be fixed.

@drinckes drinckes added the c++ label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants