AudioStream::setBufferSizeInFrames returns an unrecognized Result

[dturner]

https://github.com/google/oboe/blob/master/src/aaudio/AudioStreamAAudio.cpp#L320

When using the AAudio API AudioStream::setBufferSizeInFrames is a wrapper for AAudioStream_setBufferSizeInFrames which returns an int. On success the int contains the new buffer size or on error contains a negative error number. This int is cast to an oboe::Result.

This represents a problem because in order to check whether the call was successful one must cast the oboe::Result back to an int and check whether it's negative. This breaks the pattern of doing if (result == Result::OK)

We should update setBufferSizeInFrames to return an oboe::ErrorOrValue

[philburk]

The same issue applies to almost every get* for streams.
getFramesPerBurst() returns an int32_t frame count or a Result::ErrorNull.

https://github.com/google/oboe/blob/master/src/aaudio/AudioStreamAAudio.cpp#L350

Should setBufferSizeInFrames just return int32_t ?

Or should we change all of these functions to return ErrorOrValue ?
That seems like the right thing to do but will be very disruptive.

[dturner]

See #87

[dturner]

Fixed in #109