Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging should not be done in the callback #59

Closed
dturner opened this issue Feb 12, 2018 · 1 comment
Closed

Logging should not be done in the callback #59

dturner opened this issue Feb 12, 2018 · 1 comment
Assignees

Comments

@dturner
Copy link
Collaborator

dturner commented Feb 12, 2018

Only became apparent when testing the new read/write functionality:

LOGV("%s() read %d / %d frames from FIFO", __func__, framesTransferred, numFrames);

And

LOGV("%s() wrote %d / %d frames to FIFO", __func__, framesTransferred, numFrames);

@dturner
Copy link
Collaborator Author

dturner commented Feb 12, 2018

Closing because I've added these as comments in the PR review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants