Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving oboe samples into this repo #53

Closed
dturner opened this issue Feb 6, 2018 · 3 comments
Closed

Consider moving oboe samples into this repo #53

dturner opened this issue Feb 6, 2018 · 3 comments

Comments

@dturner
Copy link
Collaborator

dturner commented Feb 6, 2018

Why?

It's easier to keep the samples and the library in sync with one another when they're in the same repo. There have been a few instances recently where the sample and the library are incompatible because Oboe has been updated but the sample hasn't.

When making changes on a topic branch we could make sure that tests, samples and code were all updated together.

It would also make the samples' CMake configuration slightly less complex because there'd be no need to clone oboe inside of CMake.

@philburk
Copy link
Collaborator

I like the idea of having everything in sync.

Will this make it any more complicated for developers to clone just the Oboe library in their projects?

@dturner
Copy link
Collaborator Author

dturner commented Feb 12, 2018

It shouldn't - it'll just be an extra "samples" folder which contains an Android Studio project.

The only downside is that there'll be some duplication of utility functions and UI code from the high performance audio repo. Not too much of a concern.

@dturner dturner removed the question label Mar 27, 2018
@dturner
Copy link
Collaborator Author

dturner commented Mar 27, 2018

Fixed in e3e55e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants