Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with level-3 compression on some HTML #84

Closed
sunnybear opened this issue Sep 6, 2019 · 7 comments
Closed

Error with level-3 compression on some HTML #84

sunnybear opened this issue Sep 6, 2019 · 7 comments

Comments

@sunnybear
Copy link

Hello. Noticed that some HTML (example attached) is broken with brotli_comp_level 3 optimization (nor 2-, nor 4+, exactly 3). With attached HTML under brotli compression level 3 there is no symbols after line 527, position 61. With level 2 or level 4 - the whole document is correctly compressed.
brotli-3.html.txt

@eustas
Copy link
Collaborator

eustas commented Sep 6, 2019

Hello.
Could you check if it is fixed after #82?

@sunnybear
Copy link
Author

sunnybear commented Sep 6, 2019

No, it's not fixed. Issue can be reproduced with the last git source code.
Maybe it's related to brotli 1.0.7 itself.

P.S. checked with the latest brotli - no errors with quality=3

@eustas
Copy link
Collaborator

eustas commented Sep 6, 2019

I'll check it on Monday. Thanks for the report.

@eustas
Copy link
Collaborator

eustas commented Sep 6, 2019

Works for me... Could you create a PR that updates...

  • scripts/.travis-before-test.sh (fetch the file, similar to war-and-piece)
  • scripts/test.conf (set compression level)
  • scripts/.travis-test.sh(new test case)
    ... that would demonstrate the problem? Thanks.

@eustas
Copy link
Collaborator

eustas commented Sep 7, 2019

Sorry, false start. The fix is #83, and it is not yet landed.

@eustas
Copy link
Collaborator

eustas commented Sep 7, 2019

Landed

@sunnybear
Copy link
Author

Thank you. It seems issue has been resolved. Will check on production in a month, this can be closed right now.

@eustas eustas closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants