Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view_column icon does not align with integer pixels #1731

Open
leosdad opened this issue Jun 24, 2024 · 3 comments
Open

view_column icon does not align with integer pixels #1731

leosdad opened this issue Jun 24, 2024 · 3 comments
Assignees

Comments

@leosdad
Copy link

leosdad commented Jun 24, 2024

Contrary to the older Material Icons, the filled Material Symbols icon does not align with integer pixels when rendered at 24 px width. The screenshot shows how it looks in Figma at 100%:

image

A zoomed view shows the misalignment:

image

@tphinney
Copy link
Collaborator

tl;dr: as designed

So, yes, this sparked LENGTHY discussions when we were first working on the Material Symbols font a couple years ago. (Note to other viewers: the icon presented is the “Sharp” version, but the problem exists regardless.)

You did not draw the 24x24 box around the old Material Icons version. If you had, you might have noticed that… it is not centered in its box! So it has a problem, it is just a different problem.

There are a lot of tradeoffs. If the main design had 2 px outside margins, 1 px between columns, with columns 6 px wide, that would have worked, but the default (unfilled) version would have been a box shape that was wider than standard—which would have been my preferred compromise choice, but not the designer’s.

@tphinney tphinney self-assigned this Jun 24, 2024
@leosdad
Copy link
Author

leosdad commented Jun 24, 2024

tl;dr: as designed
So, yes, this sparked LENGTHY discussions...

Fully understood. Yes, the old icon is not centered. I just tried your description and I suppose I'd vote for it too. IMHO a better solution would be this:

image

i.e. 3 px wide bars. At least for the filled version it would work better. It's fully simmetrical and 100% on the grid.

@leosdad
Copy link
Author

leosdad commented Jul 2, 2024

Or this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants