From f5919025adbe6ca77bc4335d796b68d910020ea3 Mon Sep 17 00:00:00 2001 From: Adam Harwayne Date: Fri, 10 Apr 2020 16:03:40 -0700 Subject: [PATCH] Follow ups from 784. --- cmd/webhook/main.go | 1 + pkg/apis/pubsub/v1alpha1/pullsubscription_conversion_test.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/webhook/main.go b/cmd/webhook/main.go index caa5955239..041e7e29a8 100644 --- a/cmd/webhook/main.go +++ b/cmd/webhook/main.go @@ -156,6 +156,7 @@ func NewConversionController(ctx context.Context, _ configmap.Watcher) *controll }, }, }, + // We don't want to alter the incoming context, so just pass it as-is. func(ctx context.Context) context.Context { return ctx }, diff --git a/pkg/apis/pubsub/v1alpha1/pullsubscription_conversion_test.go b/pkg/apis/pubsub/v1alpha1/pullsubscription_conversion_test.go index cc461aabdd..d033ff7b30 100644 --- a/pkg/apis/pubsub/v1alpha1/pullsubscription_conversion_test.go +++ b/pkg/apis/pubsub/v1alpha1/pullsubscription_conversion_test.go @@ -145,7 +145,7 @@ var ( SubscriptionID: "subscriptionID", } - // completePullSubscription is a PullSubscription with every filled in, except TypeMeta. + // completePullSubscription is a PullSubscription with every field filled in, except TypeMeta. // TypeMeta is excluded because conversions do not convert it and this variable was created to // test conversions. completePullSubscription = &PullSubscription{