Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Autoscaling annotation should be made immutable #665

Closed
nachocano opened this issue Mar 17, 2020 · 0 comments · Fixed by #1504
Closed

Autoscaling annotation should be made immutable #665

nachocano opened this issue Mar 17, 2020 · 0 comments · Fixed by #1504
Assignees
@danyinggu
Labels
area/sources kind/bug Something isn't working kind/good-first-issue priority/2 Nice to have feature but doesn't block current release defined by release/*
Milestone
Backlog

Comments

@nachocano
Copy link
Member

Describe the bug
The autoscaling annotation should be made immutable, otherwise the correct controller won't be called if changed.

Expected behavior
Autoscaling annotation cannot be changed

To Reproduce
Change the annotation and you can save the object

Knative-GCP release version
0.13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danyinggu danyinggu

Labels
area/sources kind/bug Something isn't working kind/good-first-issue priority/2 Nice to have feature but doesn't block current release defined by release/*
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Update immutable fields for sources in v1alpha1 and v1beta1
3 participants
@grantr @nachocano @danyinggu