Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Report event_count metric in Broker Ingress when request is not a valid event #1706

Closed
Harwayne opened this issue Sep 16, 2020 · 1 comment · Fixed by #1798
Closed

Report event_count metric in Broker Ingress when request is not a valid event #1706

Harwayne opened this issue Sep 16, 2020 · 1 comment · Fixed by #1798
Assignees
@AlexandraRoatis
Labels
area/broker area/observability kind/feature-request New feature or request kind/good-first-issue priority/2 Nice to have feature but doesn't block current release defined by release/* release/2
Milestone
v0.19.0-M1

Comments

@Harwayne
Copy link
Contributor

Problem
As decided in #982, when a request is received by the Broker Ingress, but the request is not a valid cloud event, then record the event_count metrics with event type _invalid_cloud_event_ and response code 400.
@Harwayne Harwayne mentioned this issue Sep 16, 2020
Closed
@grantr
Copy link
Contributor

grantr commented Sep 22, 2020

We may want other values for different error cases.

@grantr grantr added priority/2 Nice to have feature but doesn't block current release defined by release/* release/2 labels Sep 22, 2020
@grantr grantr added this to the Backlog milestone Sep 22, 2020
@AlexandraRoatis AlexandraRoatis self-assigned this Sep 28, 2020
@Harwayne Harwayne modified the milestones: Backlog, v0.19.0-M1 Sep 29, 2020
@AlexandraRoatis AlexandraRoatis mentioned this issue Oct 5, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AlexandraRoatis AlexandraRoatis

Labels
area/broker area/observability kind/feature-request New feature or request kind/good-first-issue priority/2 Nice to have feature but doesn't block current release defined by release/* release/2
Projects
None yet
Milestone
v0.19.0-M1
Development

Successfully merging a pull request may close this issue.

Report event_count metric in Broker Ingress for invalid events AlexandraRoatis/knative-gcp
3 participants
@grantr @Harwayne @AlexandraRoatis