Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows use of Maven settings for defining registry credentials. #81

Merged
merged 29 commits into from
Feb 12, 2018
Merged

Allows use of Maven settings for defining registry credentials. #81

merged 29 commits into from
Feb 12, 2018

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Feb 9, 2018 •
edited
Loading

Fixes #80
Fixes #75

Registry credentials can be defined as servers in Maven settings (~/.m2/settings.xml):

<servers>
  ...
  <server>
    <id>gcr.io</id>
    <username>oauth2accesstoken</username>
    <password>asdfjkl;</password>
  </server>
  ...
</servers>

coollog added 24 commits February 7, 2018 11:25
@coollog
Uses credential helper for pulling base image as well.
cb61b1f
@coollog
Changes credential helpers to be a list.
a452c91
@coollog
Changes to multiple credential helpers for jib-maven-plugin.
bb65b01
@coollog
Adds image reference to RegistryUnauthorizedException.
88de538
@coollog
Fixes build steps.
9ac2c1a
@coollog
Fixes nullpointerexception.
122549b
@coollog
Merge branch 'master' into multiple-credhelpers
c622a8a
@coollog
Updates README and CHANGELOG.
b7fd773
@coollog
Updates README and CHANGELOG.
08066d1
@coollog
Merge branch 'master' into multiple-credhelpers
3d2592c
@coollog
Merge branch 'master' into multiple-credhelpers
ac990d0
@coollog
Pulls registry credentials from Maven settings.
e6d4134
@coollog
Fixes spacing.
4595dc5
@coollog
Merge branch 'multiple-credhelpers' of github.com:google/jib into mul…
6bbb7d3 
…tiple-credhelpers
@coollog
Merge branch 'master' into multiple-credhelpers
ba44f51
@coollog
Changes credentialHelperNames to credHelpers.
422c159
@coollog
Merge branch 'master' into multiple-credhelpers
1fcee9d
@coollog
Merge branch 'master' into multiple-credhelpers
1a94f75
@coollog
Merge branch 'multiple-credhelpers' into maven-settings-server
7b0e1f5
@coollog
Removes NoRegistryCredentialsException.
1119c6e
@coollog
Merge branch 'master' into multiple-credhelpers
d6c994d
@coollog
Merge branch 'multiple-credhelpers' into maven-settings-server
7c0b533
@coollog
Merge branch 'master' into maven-settings-server
5734f05
@coollog
Uses Maven server settings as known credentials for registry.
5ce6c0c
@coollog coollog added this to the 0.1.1 milestone Feb 9, 2018
@coollog coollog mentioned this pull request Feb 9, 2018
Merged
@coollog coollog merged commit 43d479a into master Feb 12, 2018
@coollog coollog deleted the maven-settings-server branch February 12, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosebazooka loosebazooka loosebazooka approved these changes

@elharo elharo Awaiting requested review from elharo

@patflynn patflynn Awaiting requested review from patflynn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@coollog @loosebazooka