Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes DockerfileTemplate resource resolution. #171

Merged
merged 4 commits into from
Mar 19, 2018
Merged

Fixes DockerfileTemplate resource resolution. #171

merged 4 commits into from
Mar 19, 2018

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Mar 14, 2018 •
edited
Loading

Paths.get(Resources.get("...").toURI()) fails with FileSystemNotFoundException. Rather, it should use Resources.toString.

@coollog coollog added this to the 0.1.6 milestone Mar 14, 2018
@coollog coollog merged commit 52a6cb2 into master Mar 19, 2018
@coollog coollog deleted the fix-dockercontext branch March 19, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosebazooka loosebazooka loosebazooka approved these changes

@TadCordle TadCordle Awaiting requested review from TadCordle

Assignees
No one assigned
Labels
area/jib-maven-plugin priority :p0
Projects
None yet
Milestone
0.1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@coollog @loosebazooka