Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ravel_pytree does not work with int input #1028

Closed
fehiepsi opened this issue Jul 18, 2019 · 0 comments · Fixed by #6136
Closed

ravel_pytree does not work with int input #1028

fehiepsi opened this issue Jul 18, 2019 · 0 comments · Fixed by #6136

Comments

@fehiepsi
Copy link
Contributor

After #897, vjp does not accept int input. Because ravel_pytree uses vjp for ravel/unravel logic, something like ravel_pytree([1]) does not work anymore. I would be nice if we are able to disable this check in vjp. Probably we can provide an optional kwargs disable_check_inexact_input in vjp function to maintain this behaviour.

cc @hawkinsp @neerajprad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

generalize ravel_pytree to handle int types jax-ml/jax
1 participant
@fehiepsi