Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev workflow] Add hook to run Flow type checks on npm run build #39

Closed
gino-m opened this issue Dec 11, 2018 · 3 comments
Closed

[Dev workflow] Add hook to run Flow type checks on npm run build #39

gino-m opened this issue Dec 11, 2018 · 3 comments
Labels
type: process Automated builds, test automation, etc.

Comments

@gino-m
Copy link
Collaborator

gino-m commented Dec 11, 2018

Described in facebook/create-react-app#5995 (comment)

@gino-m gino-m added the type: process Automated builds, test automation, etc. label Dec 11, 2018
@bugzpodder
Copy link

This is the only project in google org that uses flow? I thought google is big on typescript? Is there any reason why flow is picked over ts?

@gino-m
Copy link
Collaborator Author

gino-m commented Dec 11, 2018

When I looked into it, it seemed integrating ts with React was non-trivial, and I wanted to minimize the number of custom integrations to reduce complexity. This may have changed since, but since this is a 20%/best-effort project, I haven't had time to investigate this fully.

Also, Ground uses Firebase for db triggers and hosted functions, and the examples in the docs are primarily ES6, so I preferred to use one language across both web client and server-side. ts integration is available, but again, unfortunately I haven't had time to try it out.

@gino-m
Copy link
Collaborator Author

gino-m commented Oct 27, 2019

Obsolete; will be reimplemented in new version.

@gino-m gino-m closed this as completed Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process Automated builds, test automation, etc.
Projects
None yet
Development

No branches or pull requests

2 participants