Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent formatting between eclipse and IntelliJ #381

Closed
aharonha opened this issue Jun 20, 2019 · 3 comments
Closed

Inconsistent formatting between eclipse and IntelliJ #381

aharonha opened this issue Jun 20, 2019 · 3 comments

Comments

@aharonha
Copy link

Hey.
My team is working without specified IDE, so some of us use eclipse (as I do) and others are using IntelliJ.
After a CI build that indeed passed checkstyle validations (using mvn-checkstyle-plugin) the other guys told me that they had to re-format the source once again.

This issue goes even more complicated. As I run this command:
find . -name "*.java" | xargs -n5 -L5 -P5 -i java -jar ~/Downloads/google-java-format-1.7-all-deps.jar --replace {}
I see in git status that files have changed. This changed files seems OK to my teammates!

@tbroyer
Copy link
Contributor

tbroyer commented Jun 20, 2019

See also #19 (comment)

If you settled on Google Java Format, then use it in your Maven build too (see https://github.com/google/google-java-format#third-party-integrations) instead of Checkstyle.

@wacaine
Copy link

wacaine commented Jun 27, 2019

If you have not solved your issue yet. It may be because IntelliJ is using 1.7 and the eclipse plugin is only 1.6 . see this ticket . #331

@cushon
Copy link
Collaborator

cushon commented Dec 19, 2019

Closing as a dupe of #331.

@cushon cushon closed this as completed Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants