Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepoStatus.id needs to be int64 #806

Closed
maruel opened this issue Dec 10, 2017 · 4 comments
Closed

RepoStatus.id needs to be int64 #806

maruel opened this issue Dec 10, 2017 · 4 comments

Comments

@maruel
Copy link

maruel commented Dec 10, 2017

RepoStatus.ID is *int but it must be int64. When calling RepositoriesService.CreateStatus(), the call fails with:

json: cannot unmarshal number 4396447431 into Go struct field RepoStatus.id of type int

It broke gohci which is used for https://periph.io.

@maruel
Copy link
Author

maruel commented Dec 10, 2017

I probably observed it first because the gohci workers are built with 32 bits Go (on ARM), 64 bits Go executables are probably not affected.

@dmitshur
Copy link
Member

Thanks for reporting. This is definitely related to #597.

@maruel
Copy link
Author

maruel commented Dec 10, 2017

Thanks, indeed. Sorry I searched for "RepoStatus" but didn't search for "int64" prior filing. My bad.

In practice I worked around my immediate problem so it is not urgent for me anymore but this means no user of the library can use the CreateStatus API on a 32 bits executable right now.

@dmitshur
Copy link
Member

Thanks for the valuable report @maruel. I'll close this as duplicate of #597, make a reference to it there (because there's useful data here) so we have a single centralized place to discuss this issue and make a decision.

@dmitshur dmitshur mentioned this issue Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants