-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codecov action failing to upload for master
due to a missing token
#3439
Comments
This looks to have fixed it. |
I'm not convinced because that link says it can't find a base commit to compare against. |
It seems to now be effectively silenced which obviously is not our goal. |
@gmlewis that appears to have cleared up and I can see the report on the last PR #3441 (comment). Remember the PR that was just merged was old code without a code push event since the change. |
Woohoo! Cookin' with gas! 🎉🎉🎉 |
@gmlewis I don't think anything is going to work correctly that doesn't have e0bfae64d241126b91f29934fa753ea61cb35bbe as a base. So given the current workflow (no rebasing) the test is to have a new PR. On the workflow topic, I get the desire for no editing commits, but what is the actual impact of rebasing back onto later versions of |
I don't have any issues with rebasing itself, per se. |
In which case what are your thoughts on me rebasing #3430 on |
Sure, go for it. Sorry I'm such a pain. 😁 |
Done, let's see what happens. Not a pain, but changing my muscle memory likely made me a pain! |
Ok it's working on #3430; the comment has been updated and the Codecov commit page works. The Codecov PR page isn't working for me. |
Yes, I get a 404 Not Found for that link as well. Maybe because of the force-push?!? I dunno. |
I was getting a 404 before I rebased. |
Ah, that makes sense. |
It looks like it just broken. |
This repo has a tendency to break tooling, in general. 😂 |
It might be worth speaking to the Google Codecov admin to see if there is anything they can see. Or the Google GH admin as maybe a missing permission for the Codecov app is blocking the PR page being generated. But at least it looks like the PR feedback is working. |
The current Codecov automation is referencing a base commit which is out of date and this appears to be because the upload action fails when running on
master
due to a missing token. This can be fixed by adding a Codecov token but it also looks like it can be fixed directly in the action by enabling GitHub native OIDC tokens. I'll open a PR to include the OIDC token.The text was updated successfully, but these errors were encountered: