Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov action failing to upload for master due to a missing token #3439

Closed
stevehipwell opened this issue Jan 20, 2025 · 18 comments · Fixed by #3440
Closed

Codecov action failing to upload for master due to a missing token #3439

stevehipwell opened this issue Jan 20, 2025 · 18 comments · Fixed by #3440

Comments

@stevehipwell
Copy link
Contributor

The current Codecov automation is referencing a base commit which is out of date and this appears to be because the upload action fails when running on master due to a missing token. This can be fixed by adding a Codecov token but it also looks like it can be fixed directly in the action by enabling GitHub native OIDC tokens. I'll open a PR to include the OIDC token.

@stevehipwell
Copy link
Contributor Author

This looks to have fixed it.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

This looks to have fixed it.

I'm not convinced because that link says it can't find a base commit to compare against.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

It seems to now be effectively silenced which obviously is not our goal.

@stevehipwell
Copy link
Contributor Author

@gmlewis that appears to have cleared up and I can see the report on the last PR #3441 (comment).

Remember the PR that was just merged was old code without a code push event since the change.

@stevehipwell
Copy link
Contributor Author

@gmlewis I've merged the master branch back into #3430 so if you rerun the workflows there you should see if the Codecov report is updated.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

Woohoo! Cookin' with gas! 🎉🎉🎉
Thank you, @stevehipwell!
This is fantastic and has been plaguing this repo for over a year. I really appreciate your help!

@stevehipwell
Copy link
Contributor Author

@gmlewis I don't think anything is going to work correctly that doesn't have e0bfae64d241126b91f29934fa753ea61cb35bbe as a base. So given the current workflow (no rebasing) the test is to have a new PR.

On the workflow topic, I get the desire for no editing commits, but what is the actual impact of rebasing back onto later versions of master? For a tool like Codecov adding a merge commit to get the code from master may cause issues. This doesn't need solving now, but might be worth considering if there is an impact.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

I don't have any issues with rebasing itself, per se.
My only issue is that force-pushes are a PITA for reviewers, but it happens all the time.
So I'm careful to not make this a strict rule.
It is simply nice if it can be avoided.
Granted, sometimes it is necessary.

@stevehipwell
Copy link
Contributor Author

In which case what are your thoughts on me rebasing #3430 on master while leaving all of the commits other than the last merge commit?

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

Sure, go for it. Sorry I'm such a pain. 😁

@stevehipwell
Copy link
Contributor Author

Done, let's see what happens. Not a pain, but changing my muscle memory likely made me a pain!

@stevehipwell
Copy link
Contributor Author

Ok it's working on #3430; the comment has been updated and the Codecov commit page works. The Codecov PR page isn't working for me.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

The Codecov PR page isn't working for me.

Yes, I get a 404 Not Found for that link as well. Maybe because of the force-push?!? I dunno.
We'll see what happens with future PRs.

@stevehipwell
Copy link
Contributor Author

I was getting a 404 before I rebased.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

I was getting a 404 before I rebased.

Ah, that makes sense.

@stevehipwell
Copy link
Contributor Author

It looks like it just broken.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

This repo has a tendency to break tooling, in general. 😂

@stevehipwell
Copy link
Contributor Author

It might be worth speaking to the Google Codecov admin to see if there is anything they can see. Or the Google GH admin as maybe a missing permission for the Codecov app is blocking the PR page being generated. But at least it looks like the PR feedback is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants