Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codespaces #2362

Open
josebalius opened this issue May 7, 2022 · 14 comments
Open

Codespaces #2362

josebalius opened this issue May 7, 2022 · 14 comments

Comments

@josebalius
Copy link

I am planning on implementing support for Codespaces, see: https://docs.github.com/en/rest/codespaces

Using this issue to track that work. A couple of questions:

  • Do we prefer one large PR with the whole API implementation or multiple PRs?
  • Do we prefer to have multiple issues?

Thanks!

@gmlewis
Copy link
Collaborator

gmlewis commented May 7, 2022

  • Do we prefer one large PR with the whole API implementation or multiple PRs?

I would prefer a bunch of smaller PRs if it is all the same with you.

  • Do we prefer to have multiple issues?

I'm fine with a single issue.

When we have a lot of things to work on, we often use checkboxes in a single issue like this:

  • item 1
  • item 2

etc... feel free to use them if you find it helpful to keep you organized. You are welcome to use this issue or open a new one.
You can also go back and edit your first entry if you wish... totally up to you.

Thank you, @josebalius ! We appreciate your contributions!

@gsmachado
Copy link

@josebalius any progress on this?

@josebalius
Copy link
Author

@gsmachado I started it but never really got into it much. Are you interested in taking over the issue or in the functionality?

@gsmachado
Copy link

@josebalius I'm developing something that would need the codespaces API. If I progress with the implementation directly on the go-github repo, I will submit a PR. 😄

@gsmachado
Copy link

@josebalius do you have any branch with your preliminary code?

@josebalius
Copy link
Author

I have some code locally that I haven't pushed up. Are you interested in it?

@artificial-aidan
Copy link
Contributor

Can you push up whatever you came up with?

@artificial-aidan
Copy link
Contributor

I started with some simple implementation of codespace management. I'll post the punchlist below. Happy to split it into a new issue as well.

@artificial-aidan
Copy link
Contributor

artificial-aidan commented Jun 9, 2023

  • Codespaces
    • List codespaces in a repository for the authenticated user
    • Create a codespace in a repository
    • List devcontainer configurations in a repository for the authenticated user
    • Get default attributes for a codespace
    • Create a codespace from a pull request
    • List codespaces for the authenticated user
    • Create a codespace for the authenticated user
    • Get a codespace for the authenticated user
    • Update a codespace for the authenticated user
    • Delete a codespace for the authenticated user
    • Export a codespace for the authenticated user
    • Get dtails about a codespace export
    • Create a repository from an unpublished codespace
    • Start a codespace for the authenticated user
    • Stop a codespace for the authenticated user
  • Organizations
    • List codespaces for the organization
    • Manage access control for organization codespaces
    • Add users to codespaces billing for an organization
    • Remove users from Codespaces billing for an organization
    • List codespaces for a user in organization
    • Delete a codespace from the organization
    • Stop a codespace for an organization user
  • Organization secrets
    • List organization secrets
    • Get an organization public key
    • Get an organization secret
    • Creat or update an organization secret
    • Delete an organization secret
    • List selected repositories for an organization secret
    • Set selected repositories for an organization secret
    • Add selected repository to an organization secret
    • Remove selected repository from an organization secret
  • Machines
    • List available machine types for a repository
    • List machine types for a codespace
  • Repository Secrets
    • List repository secrets
    • Get a repository public key
    • Get a repository secret
    • Create or update a repository secret
    • Delete a repository secret
  • User secrets
    • List secrets for the authenticated user
    • Get public key for the authenticated user
    • Get a secret for the authenticated user
    • Create or update a secret for the authenticated user
    • Delete a secret for the authenticated user
    • List selected repositories for a user secret
    • Set selected repositories for a user secret
    • Add a selected repository to a user secret
    • Remove a selected repository from a user secret

@artificial-aidan
Copy link
Contributor

@gmlewis I have another branch for secret management, but still waiting on getting the CLA signed. Should I push that commit to the open PR I have, or just wait until I can get the first one merged.

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 9, 2023

Your call... whichever is most convenient for you. I'm fine either way.

@artificial-aidan
Copy link
Contributor

The impact area was pretty small. I'll add them to the existing PR while waiting for CLA followup

@KenSpur
Copy link

KenSpur commented Jun 14, 2023

Nice, also looking forward to this one. Its needed for the terraform provider

@artificial-aidan
Copy link
Contributor

I got the CLA approved, just working through getting me added to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants