Skip to content

Commit bc019ca

Browse files
authored
Update DependabotSecretsSelectedRepoIDs type to []int64 (#2794)
1 parent d6880db commit bc019ca

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

github/dependabot_secrets.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ func (s *DependabotService) ListSelectedReposForOrgSecret(ctx context.Context, o
198198
}
199199

200200
// DependabotSecretsSelectedRepoIDs are the repository IDs that have access to the dependabot secrets.
201-
type DependabotSecretsSelectedRepoIDs []string
201+
type DependabotSecretsSelectedRepoIDs []int64
202202

203203
// SetSelectedReposForOrgSecret sets the repositories that have access to a Dependabot secret.
204204
//

github/dependabot_secrets_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ func TestDependabotService_CreateOrUpdateOrgSecret(t *testing.T) {
352352
mux.HandleFunc("/orgs/o/dependabot/secrets/NAME", func(w http.ResponseWriter, r *http.Request) {
353353
testMethod(t, r, "PUT")
354354
testHeader(t, r, "Content-Type", "application/json")
355-
testBody(t, r, `{"key_id":"1234","encrypted_value":"QIv=","visibility":"selected","selected_repository_ids":["1296269","1269280"]}`+"\n")
355+
testBody(t, r, `{"key_id":"1234","encrypted_value":"QIv=","visibility":"selected","selected_repository_ids":[1296269,1269280]}`+"\n")
356356
w.WriteHeader(http.StatusCreated)
357357
})
358358

@@ -361,7 +361,7 @@ func TestDependabotService_CreateOrUpdateOrgSecret(t *testing.T) {
361361
EncryptedValue: "QIv=",
362362
KeyID: "1234",
363363
Visibility: "selected",
364-
SelectedRepositoryIDs: DependabotSecretsSelectedRepoIDs{"1296269", "1269280"},
364+
SelectedRepositoryIDs: DependabotSecretsSelectedRepoIDs{1296269, 1269280},
365365
}
366366
ctx := context.Background()
367367
_, err := client.Dependabot.CreateOrUpdateOrgSecret(ctx, "o", input)
@@ -428,23 +428,23 @@ func TestDependabotService_SetSelectedReposForOrgSecret(t *testing.T) {
428428
mux.HandleFunc("/orgs/o/dependabot/secrets/NAME/repositories", func(w http.ResponseWriter, r *http.Request) {
429429
testMethod(t, r, "PUT")
430430
testHeader(t, r, "Content-Type", "application/json")
431-
testBody(t, r, `{"selected_repository_ids":["64780797"]}`+"\n")
431+
testBody(t, r, `{"selected_repository_ids":[64780797]}`+"\n")
432432
})
433433

434434
ctx := context.Background()
435-
_, err := client.Dependabot.SetSelectedReposForOrgSecret(ctx, "o", "NAME", DependabotSecretsSelectedRepoIDs{"64780797"})
435+
_, err := client.Dependabot.SetSelectedReposForOrgSecret(ctx, "o", "NAME", DependabotSecretsSelectedRepoIDs{64780797})
436436
if err != nil {
437437
t.Errorf("Dependabot.SetSelectedReposForOrgSecret returned error: %v", err)
438438
}
439439

440440
const methodName = "SetSelectedReposForOrgSecret"
441441
testBadOptions(t, methodName, func() (err error) {
442-
_, err = client.Dependabot.SetSelectedReposForOrgSecret(ctx, "\n", "\n", DependabotSecretsSelectedRepoIDs{"64780797"})
442+
_, err = client.Dependabot.SetSelectedReposForOrgSecret(ctx, "\n", "\n", DependabotSecretsSelectedRepoIDs{64780797})
443443
return err
444444
})
445445

446446
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
447-
return client.Dependabot.SetSelectedReposForOrgSecret(ctx, "o", "NAME", DependabotSecretsSelectedRepoIDs{"64780797"})
447+
return client.Dependabot.SetSelectedReposForOrgSecret(ctx, "o", "NAME", DependabotSecretsSelectedRepoIDs{64780797})
448448
})
449449
}
450450

0 commit comments

Comments
 (0)