-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cc_library for ScopedMockLog #392
Comments
@calder It shouldn't be too hard to add this. It will add a dependency on googletest, but hopefully only when ScopedMockLog is actually used. Can you point me to some code that uses ScopedMockLog so I can check it's being made available correctly? |
@drigz: Building and running src/mock-log_test.cc under Bazel should be a pretty good test. |
Would external users expect to include it with |
Probably |
On further investigation, this isn't easy to do, since mock-log.h is not written the way the public headers are. To make it work without breaking anything else I think we'd need to move mock-log.h to src/glog/mock-log.h.in and template the namespace into it. An easier way to use ScopedMockLog with Bazel would be to vendor it into your own project and hardcode the namespace instead of including |
As far as I can tell there is currently no way of using
ScopedMockLog
from Bazel.The text was updated successfully, but these errors were encountered: