Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flat_buffers.dart putFloat64 is wrong #8070

Closed
Llamadmiral opened this issue Aug 15, 2023 · 2 comments · Fixed by #8290
Closed

flat_buffers.dart putFloat64 is wrong #8070

Llamadmiral opened this issue Aug 15, 2023 · 2 comments · Fixed by #8290

Comments

@Llamadmiral
Copy link
Contributor

Current:

flatbuffers/dart/lib/flat_buffers.dart

Lines 387 to 390 in 48da238

void putFloat64(double value) {
_prepare(_sizeofFloat64, 1);
_setFloat32AtTail(_tail, value);
}

Correct:

  void putFloat64(double value) {
    _prepare(_sizeofFloat64, 1);
    _setFloat64AtTail(_tail, value);
  }

Please fix as this makes all float64 structs wrongly encoded.
thanks
@Llamadmiral Llamadmiral mentioned this issue Aug 17, 2023
Closed
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Feb 13, 2024
@Llamadmiral
Copy link
Contributor Author

not-stale

@github-actions github-actions bot removed the stale label Feb 16, 2024
@NotTsunami NotTsunami mentioned this issue Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dart: Fix incorrect write in Float64 write method NotTsunami/flatbuffers
1 participant
@Llamadmiral