Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatbuffers Android App depends on fixed flatbuffer version #7493

Closed
dbaileychess opened this issue Aug 30, 2022 · 3 comments · Fixed by #7503
Closed

Flatbuffers Android App depends on fixed flatbuffer version #7493

dbaileychess opened this issue Aug 30, 2022 · 3 comments · Fixed by #7503

Comments

@dbaileychess
Copy link
Collaborator

@paulovap Got this catch-22 case with Android build. I am trying to upgrade to 2.0.8 but it depends on com.google.flatbuffers:flatbuffers-java:2.0.0' and it leads to a version mismatch. I feel like this code shouldn't be loading some particular package version? It should just be using whatever's defined in the repo.

I'm going to ignore this error as it just seems like some sample app, but we should explore it.

Originally posted by @dbaileychess in #7492 (comment)

@greenrobot
Copy link
Contributor

greenrobot commented Aug 30, 2022

Btw, are patch version upgrades actually breaking changes? Unrelated to Android, I was wondering if, by convention, patch version upgrades are non-breaking. And thus the check could just look at major.minor version. This would save us some dummy commits for generated files, in which is only the version changes; e.g. the static assert for versions for C++. (Seen this for 2.0.7 and 2.0.8 versions).

Doesn't have to be this solution, e.g. could be "last compatible" version for something. The goal would be to have a better signal/noise ratio for commits, if you know what I mean.

@dbaileychess
Copy link
Collaborator Author

We don't follow SemVer exactly, because we really only have one version for all the languages we support. But in general, patch level changes are non breaking.

Yes, the changes to the generate files is a tad annoying, and probably skipping the patch level would be ideal. Though this isn't the biggest issue for this repo. But I could see it as an issue for other users.

@paulovap
Copy link
Collaborator

@paulovap Got this catch-22 case with Android build. I am trying to upgrade to 2.0.8 but it depends on com.google.flatbuffers:flatbuffers-java:2.0.0' and it leads to a version mismatch. I feel like this code shouldn't be loading some particular package version? It should just be using whatever's defined in the repo.

Indeed, we can depend on the src files instead. I will leave the library dependency commented to guide the devs how to do it outside the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants