From 0280e9fd0bab77b35ef55fbd0f6bd13a6181cd7d Mon Sep 17 00:00:00 2001
From: Seth Vargo <seth@sethvargo.com>
Date: Wed, 9 Dec 2020 23:19:31 -0500
Subject: [PATCH] Return 400 on Twilio errors

These are nearly always client errors
---
 pkg/controller/issueapi/logic.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pkg/controller/issueapi/logic.go b/pkg/controller/issueapi/logic.go
index 619e6d365..1836b6868 100644
--- a/pkg/controller/issueapi/logic.go
+++ b/pkg/controller/issueapi/logic.go
@@ -265,13 +265,13 @@ func (c *Controller) issue(ctx context.Context, request *api.IssueCodeRequest) (
 				}
 
 				logger.Errorw("failed to send sms", "error", err)
-				result.obsBlame = observability.BlameServer
+				result.obsBlame = observability.BlameClient
 				result.obsResult = observability.ResultError("FAILED_TO_SEND_SMS")
 				return err
 			}
 			return nil
 		}(); err != nil {
-			result.httpCode = http.StatusInternalServerError
+			result.httpCode = http.StatusBadRequest
 			result.errorReturn = api.Errorf("failed to send sms: %s", err)
 			return result, nil
 		}