Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

CACHE_REDIS_HOST broken #405

Closed
joshgummersall opened this issue Aug 27, 2020 · 4 comments
Closed

CACHE_REDIS_HOST broken #405

joshgummersall opened this issue Aug 27, 2020 · 4 comments
Labels
kind/bug Something is malfunctioning.

Comments

@joshgummersall
Copy link

TL;DR

The way env prefixing is used in the current repo for cache configuration is broken. CACHE_ is included as a prefix twice for Redis host/port environment variables.

Expected behavior
Services with caching should work with the provided Terraform configuration

Observed behavior
Services with caching do not work.

Reproduction

Deploy from master

The fix should be to either remove the dupe env:", prefix="CACHE_" from the Redis cache config or to remove the prefix everywhere cache.Config is referenced.

@joshgummersall joshgummersall added the kind/bug Something is malfunctioning. label Aug 27, 2020
@joshgummersall
Copy link
Author

The acute fix I used was the change CACHE_REDIS_HOST to CACHE_CACHE_REDIS_HOST in Terraform files.

@sethvargo
Copy link
Member

Dupe of #400. Although that should have been already fixed depending on when you pulled.

@sethvargo
Copy link
Member

Fixed in #402. Please ensure you're on that commit or later.

@joshgummersall
Copy link
Author

Probably landed just after I pulled and deployed. Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something is malfunctioning.
Projects
None yet
Development

No branches or pull requests

2 participants