Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional no match cases for EmptyCatch #2565

Closed
Donnerbart opened this issue Sep 16, 2021 · 2 comments
Closed

Additional no match cases for EmptyCatch #2565

Donnerbart opened this issue Sep 16, 2021 · 2 comments

Comments

@Donnerbart
Copy link

I would kindly ask to re-open and merge this PR. It was linked into the last issue regarding this topic, but closed without any comment. Maybe it was auto-closed due to the Fixes #1654 when that issue was closed?

Using ignored as parameter name is the default way to suppress the empty catch warning in IntelliJ, so this is widely adapted. It would be great to support this case to remove a ton of unwanted warnings.

Are there any objections in applying this change?
If there is consensus, can the old PR be re-used or does it need to be re-created?

@cushon
Copy link
Collaborator

cushon commented Sep 16, 2021

I think this is why the PR was closed: #1654 (comment)

@Donnerbart
Copy link
Author

Oh, I actually misread the style guide as in "parameter is ..." or there is a comment.

Okay, then this will probably not be "fixed". Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants