Travis fails on all PRs

[ixdy]

It looks like the Travis configuration uses secret environment variables to log into various docker repositories, but Travis only exports these variables on postsubmit runs (to prevent them from being stolen).

As a result, all PRs fail tests, which is not a great user experience.

[bajacondor]

Does anyone at Google own this?

[KaylaNguyen]

I will look into this.

[KaylaNguyen]

By default, Travis tests fail on all external PRs due to security reason: https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
You are correct. We do use secret environment variables for logins. During Travis run, contributors can run malicious scripts to get those credentials and we of course don't want that.

There are ways to work around, e.g. https://blog.algolia.com/travis-encrypted-variables-external-contributions/ and discussion about it, e.g. OHDSI/Achilles#165

Since currently there's no plan to maintain this repository, I would only consider urgent CLs to merge in our codebase. Our suggestion is to migrate to our Golang library as Github is the source of truth for the repo and is actively maintained - https://github.com/google/go-containerregistry

Thanks for your understanding.