Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port recent changes from tcnative #31

Open
nmittler opened this issue Jan 11, 2017 · 5 comments
Open

Port recent changes from tcnative #31

nmittler opened this issue Jan 11, 2017 · 5 comments
Assignees
Milestone

Comments

@nmittler
Copy link
Contributor

nmittler commented Jan 11, 2017

There have been a few fixes/improvements lately in netty-tcnative. We should port those over to our engine.

A few that immediately stick out:

netty/netty-tcnative#205
(and related netty/netty#6123)

netty/netty-tcnative#207
netty/netty-tcnative#210

netty/netty-tcnative#216
(and related netty/netty#6201)

netty/netty#6118
netty/netty#6113
netty/netty#6090
netty/netty#6089
netty/netty#6439

SSLEngine benchmarks:
netty/netty#6360

@nmittler nmittler added this to the 1.0.0 milestone Jan 11, 2017
@nmittler nmittler self-assigned this Jan 11, 2017
@nmittler
Copy link
Contributor Author

@normanmaurer @Scottmitch @davidben any other PRs that I should absorb from netty land?

@Scottmitch
Copy link

Scottmitch commented Jan 11, 2017

netty/netty-tcnative#211. I haven't looked at the new conscrypt code but generally everything that is not cleanup should be interesting and at least worth a look.

@nmittler
Copy link
Contributor Author

@Scottmitch thanks!

Going forward, It should probably be a goal for conscrypt to make the engine as much of a copy-and-paste from Netty as possible in order to allow us to easily absorb multiple changes all at once.

@Scottmitch
Copy link

sgtm ... should make sharing easier in both directions (not sure if you are actively developing conscrypt or just happy to take Netty's improvements).

@nmittler
Copy link
Contributor Author

We will be actively developing conscrypt, but I expect most of the syncing will be netty->conscrypt at least at the beginning. We also eagerly look forward to contributions from @normanmaurer and @Scottmitch 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants