Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation errors #553

Closed
l46kok opened this issue Jun 15, 2022 · 1 comment
Closed

Documentation errors #553

l46kok opened this issue Jun 15, 2022 · 1 comment
Assignees

Comments

@l46kok
Copy link
Collaborator

l46kok commented Jun 15, 2022

Output should be interpreter.emptyActivation instead of interpreter.mapActivation:

=== Exercise 1: Hello World ===

------ input ------
(interpreter.emptyActivation)

------ result ------
value: Hello, World! (types.String)

call to cel.Declarations missing a trailing comma:

    env, _ := cel.NewEnv(
      cel.Declarations(
        decls.NewVar("now", decls.Timestamp),
      )**,**
    )

The documentation states midway that we should get an error for undeclared reference to jwt:

ERROR: <input>:4:16: undeclared reference to 'jwt' (in container 'google.rpc.context.AttributeContext')
 |     principal: jwt.iss + '/' + jwt.sub,
 | ...............^

The code sample above this error message already contains the needed declaration, so this error is never encountered.
(The instruction asks you to specify the container first, run the code and declare the variables afterwards to address the error so perhaps just the sample code needs be moved below, or split into two steps for better clarity)

Building Protos section at the bottom is a duplicate from the previous exercise and should be removed here. Looks like the additional considerations disclaimer should also be moved to the previous exercise.

@TristonianJones
Copy link
Collaborator

Fixed upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants