Comparing timestamps?

[mholt]

Hi, sorry for the lame question -- how can I compare timestamps using CEL + this library?

I tried timestamp(0) == timestamp(0) but I get false every time.

Is there a reference I could read about how to do this?

[TristonianJones]

That should work. Let me add a quick conformance test and get back to you.

[mholt]

It's very possible there is a bug on my end too -- I will dig down more, now that I know that should work.

[TristonianJones]

Ah, there's no overload for timestamp from epoch:
type conversion error from 'int' to 'google.protobuf.Timestamp', wanted true

We could add one if you like. I see no reason not to support this.

[TristonianJones]

@mholt This is a bug on our side. Sorry about this. It's clearly in the checker, but not in the interpreter.

[mholt]

No worries, thanks for checking!

My objective is to compare timestamps. I would prefer to use == < > operators since they are so convenient. If it's not too much trouble, I think it could be really useful.

[TristonianJones]

Oh, yes, the comparisons are certainly supported. The problem is that the function declaration was added to the Go type-checker, but not the interpreter. We missed it in our conformance audit since the spec indicates that only timestamp(string) is supported. I'll add an issue to update the spec, but will fix the Go implementation shortly.

[TristonianJones]

@mholt I'll put together a point release once this is checked in.

[mholt]

Thanks! That's fast!

[TristonianJones]

@mholt You should be all set to bump up to v0.5.1 :) Thanks for the reaching out!

[mholt]

Works like a charm. Thank you very much!