Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a classes property to the JSON block definitions to add CSS classes #8271

Closed
BeksOmega opened this issue Jul 10, 2024 · 4 comments
Closed

Add a classes property to the JSON block definitions to add CSS classes #8271

BeksOmega opened this issue Jul 10, 2024 · 4 comments
Assignees
@ishon19
Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

Dependent on #8270

To Fix

In the BlockSvg class, Override the jsonInit method to take the value of the json['classes'] property, concatenate it if it is an array, and pass it to the this.addClass method.

The PR to fix this should be made against the rc/v12.0.0 branch.

To work on this issue, please comment below asking to be assigned.
@BeksOmega BeksOmega added help wanted External contributions actively solicited PR: feature Adds a feature good first issue labels Jul 10, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 10, 2024
@BeksOmega BeksOmega added issue: feature request Describes a new feature and why it should be added and removed PR: feature Adds a feature labels Jul 10, 2024
@ishon19 ishon19 mentioned this issue Jul 11, 2024
Closed
@ishon19
Copy link

ishon19 commented Jul 11, 2024

Hey @BeksOmega, I'd like to work on this issue! 👋

@BeksOmega
Copy link
Collaborator Author

Sweet! Thanks for commenting, I know it's a bit annoying :P

@ishon19
Copy link

ishon19 commented Jul 11, 2024

Sweet! Thanks for commenting, I know it's a bit annoying :P

Thanks for assigning and no problem at all! Getting started on it :)

@ishon19 ishon19 mentioned this issue Jul 16, 2024
Merged
1 task
@BeksOmega
Copy link
Collaborator Author

Closed by #8377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishon19 ishon19

Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
v12
Development

No branches or pull requests
2 participants
@ishon19 @BeksOmega