fix: remove deprecated use of objectUtils from generators #6499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Some generators give a deprecation warning when used.
Proposed Changes
Uses
Object.valuesinstead of deprecated objectUtils.Behavior Before Change
Behavior After Change
No change.
Reason for Changes
Test Coverage
Tested in the Code demo in core. Previously, got deprecation warnings in JS, Lua, and PHP generators. Now, no warnings.
Documentation
Additional Information
Checked and objectUtils is not used anywhere else in core.
We should consider patching this as it will affect almost all developers and they have no way of addressing this warning on their end. It's just a console message so it's probably not worth starting a patch just for this, but if we have to do one for another reason I think we should include it.