fix: some AnyDuringMigration #6430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
approved these changes
Sep 14, 2022
core/block.ts
Outdated
| @@ -761,8 +759,6 @@ export class Block implements IASTNodeLocation, IDeletable { | |||
| const blocks = [this]; | |||
| const childBlocks = this.getChildren(ordered); | |||
| for (let child, i = 0; child = childBlocks[i]; i++) { | |||
| // AnyDuringMigration because: Argument of type 'Block[]' is not | |||
| // assignable to parameter of type 'this[]'. | |||
| blocks.push(...child.getDescendants(ordered) as AnyDuringMigration); | |||
There was a problem hiding this comment.
Did you mean to remove the cast here as well?
There was a problem hiding this comment.
I meant to leave the comment in because the cast was not trivially resolved. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Part of the outstanding AnyDuringMigration issues.
Proposed Changes
Fix some leftover AnyDuringMigrations where no code change was needed.
Behavior Before Change
No change
Behavior After Change
No change
Reason for Changes
Cleanup
Test Coverage
Mocha