fix: generator type declarations #6412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #6358
Proposed Changes
Fixes the type declarations for the generators. They're still typed as
anyuntil we actually convert the generators to typescript, but at least the declarations match the way you're supposed to import the generators.Behavior Before Change
Import5ing the generators the correct way would result in type errors.
Behavior After Change
No type errors!
Reason for Changes
Type errors make me sad =(
Test Coverage
Linked to the dev tools plugin with google/blockly-samples#1236 implemented.
Documentation
We need to update the documentation on importing the generators before the release. But that's my job!
Additional Information
N/A