fix: improve types in touch code #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
approved these changes
Apr 21, 2022
This was referenced Apr 21, 2022
This was referenced Oct 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Proposed Changes
Add specificity to types in touch code.
I added more specific types where possible (e.g. with
instanceof) but left fallbacks to the old code with casts to?, to avoid accidentally changing behaviour in the edge cases.Reason for Changes
Part of #5857
Fix or mask type errors.
Test Coverage
Tested on desktop chrome and through device emulation in chrome dev tools, acting as a pixel 5.
Additional Information
#6097 tracks future cleanup.
caniuse.com says pointer events are supported in all browsers we support, so we can refactor and simplify this code--but we'll need to do a lot of testing to verify it.