Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for renamings.js #5645

Closed
alschmiedt opened this issue Oct 27, 2021 · 1 comment · Fixed by #5980
Closed

Add test for renamings.js #5645

alschmiedt opened this issue Oct 27, 2021 · 1 comment · Fixed by #5980
Assignees
@cpcallen
Labels
issue: feature request Describes a new feature and why it should be added

Comments

@alschmiedt
Copy link
Contributor

alschmiedt commented Oct 27, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
We have a new renamings.js file that we plan on using to help developers update easier. We need to make sure this files is formatted properly when it is updated. See google/blockly-samples#924 for more information.

Describe the solution you'd like
A test that is run during CI to check that the format of renamings.js is correct and valid.

Describe alternatives you've considered

Additional context
@alschmiedt alschmiedt mentioned this issue Oct 27, 2021
Closed
@alschmiedt alschmiedt added issue: feature request Describes a new feature and why it should be added internal External contributions not accepted and removed internal External contributions not accepted labels Oct 27, 2021
@cpcallen cpcallen self-assigned this Oct 28, 2021
@cpcallen cpcallen mentioned this issue Mar 4, 2022
Merged
9 tasks
@cpcallen cpcallen linked a pull request Mar 4, 2022 that will close this issue
feat(tests): Add a test to validate scripts/migration/renamings.js #5980
Merged
9 tasks
@cpcallen
Copy link
Contributor

cpcallen commented Mar 9, 2022

Closed by #5980.

@cpcallen cpcallen closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpcallen cpcallen

Labels
issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(tests): Add a test to validate scripts/migration/renamings.js google/blockly
2 participants
@cpcallen @alschmiedt