You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The places where BlockStyle is consumed (e.g. in a renderer) need all three of those values, they just don't need to be provided by the developer. However, it appears that in some places we do reference the BlockStyle type in a place where it would make sense to allow undefined values, e.g. in the Blockly.Theme constructor. I think with Blockly.Theme.defineTheme just accepting an Object as parameter, we're losing some type information that allows this situation to occur. It does look like this area could use some type cleanup, but I'm not sure the solution is to just make those properties optional. We might want separate types for the input vs the output after validation, or just stop using the Theme type before validation. Thanks for flagging this!
Typings here are as follows:
but should be
to match docs here
The text was updated successfully, but these errors were encountered: