Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goog.inherits in custom fields documentation #4559

Closed
1 of 3 tasks
BeksOmega opened this issue Dec 28, 2020 · 1 comment
Closed
1 of 3 tasks

goog.inherits in custom fields documentation #4559

BeksOmega opened this issue Dec 28, 2020 · 1 comment
Assignees
@rachel-fenichel
Labels
issue: docs Describes missing or incorrect documentation
Milestone
2021_q1_release

Comments

@BeksOmega
Copy link
Collaborator

Where

  1. At the bottom of the implementing a constructor code sample.
  2. At the bottom of the subclassing code sample.

What

  • Text (Code)
  • Image or Gif
  • Other

Old content

goog.inherits

Suggested content

Blockly.utils.object.inherits

Additional context

Currently the linked code samples show using goog.inherits for inheritance, when they should use Blockly.utils.object.inherits (since Blockly moved away from closure).
@BeksOmega BeksOmega added issue: triage Issues awaiting triage by a Blockly team member issue: docs Describes missing or incorrect documentation labels Dec 28, 2020
@rachel-fenichel rachel-fenichel self-assigned this Jan 4, 2021
@moniika moniika added this to the 2021_q1_release milestone Jan 5, 2021
@moniika moniika removed the issue: triage Issues awaiting triage by a Blockly team member label Jan 5, 2021
@rachel-fenichel
Copy link
Collaborator

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachel-fenichel rachel-fenichel

Labels
issue: docs Describes missing or incorrect documentation
Projects
None yet
Milestone
2021_q1_release
Development

No branches or pull requests
3 participants
@moniika @rachel-fenichel @BeksOmega