Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable stricterMissingRequire in build_tasks #4457

Closed
rachel-fenichel opened this issue Nov 17, 2020 · 2 comments
Closed

Enable stricterMissingRequire in build_tasks #4457

rachel-fenichel opened this issue Nov 17, 2020 · 2 comments
Labels
issue: feature request Describes a new feature and why it should be added
Milestone
2021_q3_release

Comments

@rachel-fenichel
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The closure compiler now has a flag to check for missing requires.

Describe the solution you'd like

Enable the flag and fix missing requires.

Describe alternatives you've considered

Ignore it.
@rachel-fenichel rachel-fenichel added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Nov 17, 2020
@samelhusseini samelhusseini removed the issue: triage Issues awaiting triage by a Blockly team member label Nov 30, 2020
@rachel-fenichel rachel-fenichel added this to the 2021_q1_release milestone Dec 3, 2020
@samelhusseini samelhusseini mentioned this issue Jan 11, 2021
Merged
3 tasks
@samelhusseini
Copy link
Contributor

As of Jan 2021, this is enabled through missingRequire. Disabled temporarily in #4581

@rachel-fenichel rachel-fenichel mentioned this issue Jan 15, 2021
Closed
3 tasks
@rachel-fenichel
Copy link
Collaborator Author

Bumping to q2 milestone, but we removed about 500 of these warnings during q1.

@rachel-fenichel rachel-fenichel mentioned this issue Sep 21, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
2021_q3_release
Development

No branches or pull requests
3 participants
@rachel-fenichel @samelhusseini @alschmiedt