Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Correct date field test assertions #1673

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Fix: Correct date field test assertions #1673

merged 1 commit into from
Apr 24, 2023

Conversation

NeilFraser
Copy link
Contributor

Assert on the expected value rather than the input value.

Apparently unique to the date field.

@NeilFraser
Fix: Correct date field test assertions
1062686 
Assert on the expected value rather than the input value.
@NeilFraser NeilFraser requested a review from a team as a code owner April 24, 2023 19:52
@NeilFraser NeilFraser requested review from cpcallen and removed request for a team April 24, 2023 19:52
@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen April 24, 2023 19:54
@BeksOmega BeksOmega assigned BeksOmega and unassigned cpcallen Apr 24, 2023
@NeilFraser NeilFraser merged commit 9974e85 into master Apr 24, 2023
@NeilFraser NeilFraser deleted the fraser-assert branch April 24, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega Awaiting requested review from BeksOmega

Assignees

@BeksOmega BeksOmega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeilFraser @BeksOmega @cpcallen