-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support VTT in Matroska #9886
Comments
I think sending a PR with what you've got so far makes sense. Heads up: We have some work planned that will change how subtitle data flows from muxed formats like MKV to the Some background: Currently we put samples in the If you get the PR in before we start that work in |
I'm going to mark this as low priority to indicate that we (exoplayer-team) have no immediate plans to directly work on implementing this - but we will of course prioritise reviewing and merging any PRs you send us! |
I would also like this feature. yt-dlp, for example, downloads all subtitles in vtt format. I have the following options for watching the videos with subtitles:
Both options are not really nice. |
I'm looking into adding support for WebVTT embedded in Matroska (MKV).
I managed to get basic support in this patch: https://github.com/moneytoo/ExoPlayer/commit/09b07da83fb9cf6a0a6e511e7c0f6282c963e1da and it seems to be working with the sample provided to me in here: moneytoo/Player#249
The patch still lacks support for styles as described in Matroska specs. I'm planning on looking into the styles as well, but I'm pretty busy lately so I'm wondering if I should send you PR with this basic support (is it worth an attempt?) or better wait and finish it all?
The text was updated successfully, but these errors were encountered: