Add support for RF64 wave files #9543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-vde
reviewed
Oct 14, 2021
...ary/extractor/src/main/java/com/google/android/exoplayer2/extractor/wav/WavHeaderReader.java
Outdated
Show resolved
Hide resolved
|
I added a unit test and fixed a bug i found along the way. |
kim-vde
reviewed
Oct 15, 2021
| @@ -53,4 +53,10 @@ public void sample_imaAdpcm() throws Exception { | |||
| ExtractorAsserts.assertBehavior( | |||
| WavExtractor::new, "media/wav/sample_ima_adpcm.wav", simulationConfig); | |||
| } | |||
|
|
|||
| @Test | |||
| public void sample_RF64() throws Exception { | |||
There was a problem hiding this comment.
You also need to generate the dump files that go with the test. To do so, you need to,
- Set DUMP_FILE_ACTION to WRITE_TO_LOCAL in DumpFileAsserts.java
- Run the test. This will create dump files that are a summary of the data extracted by the WavExtractor.
- Set DUMP_FILE_ACTION back to COMPARE_WITH_EXISTING.
- Run the test. This will compare the extracted data with the files previously generated. This test need to pass.
There was a problem hiding this comment.
Just added the dump files and the test is passing :)
...ary/extractor/src/main/java/com/google/android/exoplayer2/extractor/wav/WavHeaderReader.java
Outdated
Show resolved
Hide resolved
tonihei
pushed a commit
that referenced
this pull request
Nov 1, 2021
This refactoring is the basis to support RF64 (see Issue: #9543). #minor-release PiperOrigin-RevId: 406377924
|
I don't know why its saying there is a conflicting file. There shouldn't be because I have rebased my branch on the latest dev-v2 commit. |
|
Hey! I am currently working on merging this PR. I had to make some refactorings to make the code 100% correct. You don't need to do anything. The code PR should be merged in the following days/weeks. |
tonihei
pushed a commit
that referenced
this pull request
Nov 3, 2021
This refactoring is the basis to support RF64 (see Issue: #9543). #minor-release PiperOrigin-RevId: 407301056
tonihei
pushed a commit
that referenced
this pull request
Nov 4, 2021
This refactoring is the basis to support RF64 (see Issue: #9543). #minor-release PiperOrigin-RevId: 407301056
icbaker
pushed a commit
to androidx/media
that referenced
this pull request
Nov 9, 2021
This refactoring is the basis to support RF64 (see Issue: google/ExoPlayer#9543). #minor-release PiperOrigin-RevId: 406377924
icbaker
pushed a commit
to androidx/media
that referenced
this pull request
Nov 9, 2021
This refactoring is the basis to support RF64 (see Issue: google/ExoPlayer#9543). #minor-release PiperOrigin-RevId: 407301056
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for RF64 wave files without breaking the existing support for RIFF wave files