Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer is not filled as intended for Dash mpd with multiple periods #5182

Closed
juechemparathy opened this issue Dec 2, 2018 · 2 comments
Closed
Assignees

Comments

@juechemparathy
Copy link

juechemparathy commented Dec 2, 2018

https://gist.github.com/juechemparathy/ce40519847c5d4bc3451d5b5b680f5fc
Above mpd has each segment as ~4s periods and I see that at any point only 4s of buffer is loaded instead of accumulating till the HighWaterMark level set on LoadController.

Exoplayer version: 2.9.0
Stream info:

    {
       "name": "LIVE - Multiple Periods",
       "uri": "https://content.uplynk.com/channel/3c367669a83b4cdab20cceefac253684.mpd?ad=cleardashnew",
       "drm_scheme": "widevine",
       "drm_multi_session": true,
       "drm_license_url": "https://content.uplynk.com/wv",
       "drm_key_request_properties": {
         "X-DASH-SEND-ALL-KEYS": "1"
       },
       "extension": "mpd"
     } 

Live stream has 3 minutes of slate and 3 minutes of DRM content rolling.
Slate is represented as mulitple periods of 4s.

Red box indicate buffer state during the slate.
screen shot 2018-11-30 at 12 48 08 pm

@ojw28 ojw28 self-assigned this Dec 2, 2018
@ojw28 ojw28 added the duplicate label Dec 2, 2018
@ojw28
Copy link
Contributor

ojw28 commented Dec 2, 2018

I think the buffer probably is being filled as intended, but that the position is being reported incorrectly. I'm also fairly sure it was fixed in 2.9.1. The corresponding line in the release notes is:

Fix issue where the buffered position was not updated correctly when transitioning between periods (#4899).

If you still see this behavior in 2.9.1 or later, please let us know! Marking as a duplicate of #4899

@ojw28 ojw28 closed this as completed Dec 2, 2018
@juechemparathy
Copy link
Author

LGTM with 2.9.1. Thanks.

@google google locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants