Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExoPlayer Flac Extension build instructions produce "use of undeclared identifier 'memset'" error #2975

Closed
oikmar opened this issue Jun 20, 2017 · 3 comments
Labels

Comments

@oikmar
Copy link

oikmar commented Jun 20, 2017

Issue description

To enable playback of FLAC media, we are trying to include the flac libraries following instructions in the flac-extension. following the build instructions, the ndk-build fails with the following error:

"error: use of undeclared identifier 'memset' memset(&mWriteHeader, 0, sizeof(mWriteHeader));"

Reproduction steps

Follow the build instructions for flac extension.

Link to test content

sent a terminal log to the dev email.

Version of ExoPlayer being used

release-v2

Device(s) and version(s) of Android being used

Building on MacOs version 10.12.5.
installed NDK version: 15.0.4075724

an issue search did not turn up anything similar.

@oikmar
Copy link
Author

oikmar commented Jun 21, 2017

i have built other extensions (opus, for instance) successfully. so, i think the tool-chain is working.

@oikmar
Copy link
Author

oikmar commented Jun 21, 2017

was able to build flac-1.3.1 with the above fix.

@ojw28 ojw28 added the bug label Jun 21, 2017
@ojw28 ojw28 closed this as completed Jun 26, 2017
@ojw28
Copy link
Contributor

ojw28 commented Jun 26, 2017

Fixed in dev-v2 in a7ed199

@google google locked and limited conversation to collaborators Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants