Rename tree_scalar_mul to tree_scale
#1196
Comments
This was referenced Feb 16, 2025
|
hey @carlosgmartin can you have a look at my PR and help figuring out what's possibly going wrong? |
|
Hey @aryanmahawar205 thanks for the contribution! I followed up on your PR #1198 |
|
Hey @rdyro, if this issue isn't closed can i work on it? |
|
The PR is in progress here: #1198 by @aryanmahawar205 but in case work have stalled, it'd be great if you could take a look! |
shreyans413
added a commit
to shreyans413/optax
that referenced
this issue
Mar 6, 2025
…_add_scale with deprecation warnings (google-deepmind#1196)
shreyans413
added a commit
to shreyans413/optax
that referenced
this issue
Mar 6, 2025
…_add_scale with deprecation warnings (google-deepmind#1196)
shreyans413
added a commit
to shreyans413/optax
that referenced
this issue
Mar 6, 2025
…_add_scale with deprecation warnings (google-deepmind#1196)
Thanks for pointing this out! Since the previous PR (#1198) seemed inactive, I have submitted a new PR (#1223 ) to ensure progress on this. Let me know if any further changes are needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Minor suggestion: For convenience, rename
tree_scalar_multotree_scaletree_add_scalar_multotree_add_scalewhich are more concise.
If adopted, this could be done as follows:
I can submit a PR for this.
The text was updated successfully, but these errors were encountered: