Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issues with colab #191

Closed
lanctot opened this issue Apr 17, 2020 · 6 comments
Closed

Known issues with colab #191

lanctot opened this issue Apr 17, 2020 · 6 comments
Assignees
Labels
contribution welcome It's a nice feature! But we do not have the time to do it ourselves. Contribution welcomed!

Comments

@lanctot
Copy link
Collaborator

lanctot commented Apr 17, 2020

It seems that the some packages on colab servers have been upgraded (e.g. sonnet) causing some backward-compatibility issues with the Python learning algorithms. (See some discussion here: #190)

We know about it, but we're not sure when we will be able to fix this. If anybody works out what to fix, a PR would be greatly appreciated!

@lanctot lanctot added the contribution welcome It's a nice feature! But we do not have the time to do it ourselves. Contribution welcomed! label Apr 17, 2020
@lanctot
Copy link
Collaborator Author

lanctot commented Apr 27, 2020

Quick update that we are working on getting OpenSpiel to work on Ubuntu 20.04 (see #166). I think those fixes will also mostly fix colab, so stay tuned!

@lanctot lanctot pinned this issue Apr 28, 2020
@yarncraft
Copy link
Contributor

Hello again @lanctot, I have been able to construct a Dockerized OpenSpiel JupyterLab so that users can experiment with the code and write new algorithms in the popular Jupyter Notebook environment.

Thanks to Docker you can also deploy it on a larger VM without a hassle (we are doing this with a Compute Optimized Azure instance at the moment) and have an amazing development workflow.

When I have some time left I will push my changes!

image
image

@lanctot
Copy link
Collaborator Author

lanctot commented May 13, 2020

This looks awesome! Thanks @yarncraft for your continued contributions :)

@dhennes dhennes self-assigned this May 13, 2020
@sullins2
Copy link

This might not be a complete fix, but in some cases simply reverting to Tensorflow 1.x will make everything work. I have been using policy_gradients.py, for example, and currently Colab will spit out a bunch of errors. Simply run a cell with this first and it will work:

%tensorflow_version 1.x

@lanctot
Copy link
Collaborator Author

lanctot commented May 15, 2020

Nice, thanks @sullins2!

And, actually, small update on this: thanks to @dhennes, our Monday update will have a fix that should solve a lot of the current problems with colab, too!

@yarncraft
Copy link
Contributor

I submitted a PR that offers a good alternative:
#219

@lanctot lanctot unpinned this issue May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome It's a nice feature! But we do not have the time to do it ourselves. Contribution welcomed!
Projects
None yet
Development

No branches or pull requests

4 participants