Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide bzlmod support #5605

Open
Algomorph opened this issue Sep 3, 2024 · 6 comments
Open

Provide bzlmod support #5605

Algomorph opened this issue Sep 3, 2024 · 6 comments
Assignees
Labels
platform:c++ Issues specific to C++ framework in mediapipe stat:awaiting googler Waiting for Google Engineer's Response task::all All tasks of MediaPipe type:feature Enhancement in the New Functionality or Request for a New Solution

Comments

@Algomorph
Copy link

MediaPipe Solution (you are using)

N/A

Programming language

C++

Are you willing to contribute it

No

Describe the feature and the current behaviour/state

bzlmod is not supported throughout dependency tree.

Will this change the current API? How?

No.

Who will benefit with this feature?

Anyone using MediaPipe code in a Bazel project. MediaPipe developers themselves.

Please specify the use cases for this feature

Import MediaPipe in 3rd party Bazel project, enjoy a much more subdued dependency hell.

Any Other info

Lack of TensorFlow bzlmod support (and outdated protbuf, gRPC) are probably holding this back. Need to first fix those deps. Related issues: tensorflow/tensorflow#62598, tensorflow/tensorflow#62599

@Algomorph Algomorph added the type:feature Enhancement in the New Functionality or Request for a New Solution label Sep 3, 2024
@Algomorph
Copy link
Author

Side comment: this, among a few other things, will be critical to whether we (at my company) continue using MediaPipe in the long term or gradually phase it out, along with TensorFlow and Bazel.

@kuaashish kuaashish assigned kuaashish and unassigned ayushgdev Sep 4, 2024
@kuaashish kuaashish added platform:c++ Issues specific to C++ framework in mediapipe task::all All tasks of MediaPipe labels Sep 4, 2024
@kuaashish
Copy link
Collaborator

Hi @Algomorph,

Could you please provide more details on this feature to help us better understand it?

Thank you!!

@kuaashish kuaashish added the stat:awaiting response Waiting for user response label Sep 4, 2024
@Algomorph
Copy link
Author

@kuaashish Bzlmod is the new dependency system for Bazel that addresses the shortcomings of WORKSPACE files, which are due to be removed w/ Bazel 9. You can read more about the migration process here.

Again, it is my understanding that the sole reason MediaPipe doesn't use Bzlmod right now is because TensorFlow is still using old versions of things that predate Bzlmod support (see "Other Info" in issue description above for relevant links). It may make sense to assist the TensorFlow maintainers with this issue, since support is appears to be behind the curb on those issues.

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Waiting for user response label Sep 4, 2024
@kuaashish
Copy link
Collaborator

Hi @Algomorph,

Thank you for providing additional details. We are marking this as a feature request and will share it with our team. However, we cannot provide a timeline or confirm if it will be supported, as it will depend on further demand and discussions.

@kuaashish kuaashish added the stat:awaiting googler Waiting for Google Engineer's Response label Sep 5, 2024
@udaya2899
Copy link

udaya2899 commented Sep 6, 2024

I just want to add that the current WORKSPACE support will be disabled by default in Bazel 8, and removed in Bazel 9, per: https://blog.bazel.build/2023/12/11/bazel-7-release.html#bzlmod

Once bzlmod support is added and also this repository added to github.com/bazelbuild/bazel-central-registry, mediapipe will show up in registry.bazel.build and users can simply do

bazel_dep(name = "mediapipe", version = "123")

and use it directly without having to manually install transitive dependencies or clashing toolchains.

@Algomorph
Copy link
Author

Algomorph commented Oct 4, 2024

@kuaashish or @schmidt-sebastian do you have any updates for the community on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:c++ Issues specific to C++ framework in mediapipe stat:awaiting googler Waiting for Google Engineer's Response task::all All tasks of MediaPipe type:feature Enhancement in the New Functionality or Request for a New Solution
Projects
None yet
Development

No branches or pull requests

5 participants