fix: Broken caching of type adapters

Author: autaut03

src/GoodPhp/Serialization/Serializer/Registry/Cache/CachingTypeAdapterRegistry.php

@@ -0,0 +1,43 @@
+<?php
+
+namespace GoodPhp\Serialization\Serializer\Registry\Cache;
+
+use Ds\Map;
+use GoodPhp\Reflection\Reflection\Attributes\ArrayAttributes;
+use GoodPhp\Reflection\Reflection\Attributes\Attributes;
+use GoodPhp\Reflection\Type\Type;
+use GoodPhp\Serialization\Serializer;
+use GoodPhp\Serialization\Serializer\Registry\TypeAdapterRegistry;
+use GoodPhp\Serialization\TypeAdapter\TypeAdapter;
+use GoodPhp\Serialization\TypeAdapter\TypeAdapterFactory;
+use Illuminate\Support\Arr;
+
+final class MemoizingTypeAdapterRegistry implements TypeAdapterRegistry
+{
+	/** @var array<class-string, array<>> */
+	private array $resolved = [];
+
+	public function __construct(
+		private readonly TypeAdapterRegistry $delegate,
+	) {
+	}
+
+	public function forType(string $typeAdapterType, Serializer $serializer, Type $type, Attributes $attributes = new ArrayAttributes(), TypeAdapterFactory $skipPast = null): TypeAdapter
+	{
+		$this->resolved[$typeAdapterType][(string) $type] ??= new \WeakMap();
+
+		$matchingFactories = $this->resolved[$typeAdapterType][(string) $type][$skipPast ?? $serializer] ??= [];
+
+		$attributesFactoryPair = Arr::first($matchingFactories, fn (array $pair) => $attributes->allEqual($pair[0]));
+
+		if ($attributesFactoryPair) {
+			return $attributesFactoryPair[1];
+		}
+
+		$factory = $this->delegate->forType($typeAdapterType, $serializer, $type, $attributes, $skipPast);
+
+		$this->resolved[$typeAdapterType][(string) $type][$skipPast ?? $serializer][] = [$attributes, $factory];
+
+		return $factory;
+	}
+}

src/GoodPhp/Serialization/Serializer/Registry/Cache/MemoizingTypeAdapterRegistry.php

@@ -7,7 +7,7 @@
 use GoodPhp\Reflection\Type\Type;
 use GoodPhp\Serialization\Hydration\ConstructorHydrator;
 use GoodPhp\Serialization\Hydration\Hydrator;
-use GoodPhp\Serialization\Serializer\Registry\Cache\CachingTypeAdapterRegistry;
+use GoodPhp\Serialization\Serializer\Registry\Cache\MemoizingTypeAdapterRegistry;
 use GoodPhp\Serialization\Serializer\Registry\Factory\FactoryTypeAdapterRegistryBuilder;
 use GoodPhp\Serialization\Serializer\TypeAdapterRegistrySerializer;
 use GoodPhp\Serialization\TypeAdapter\Json\FromPrimitiveJsonTypeAdapterFactory;
@@ -158,7 +158,7 @@ public function build(): Serializer
 			->addFactoryLast(new FromPrimitiveJsonTypeAdapterFactory());
 
 		return new TypeAdapterRegistrySerializer(
-			new CachingTypeAdapterRegistry($typeAdapterRegistryBuilder->build()),
+			new MemoizingTypeAdapterRegistry($typeAdapterRegistryBuilder->build()),
 			$this->reflector()
 		);
 	}