Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] favicon incorrectly fetch #161

Open
rllola opened this issue Dec 16, 2024 · 2 comments
Open

[Bug] favicon incorrectly fetch #161

rllola opened this issue Dec 16, 2024 · 2 comments

Comments

@rllola
Copy link

rllola commented Dec 16, 2024

Describe the bug
The favicon is not correctly fetch and text is showed instead.

To Reproduce
Steps to reproduce the behavior:

  1. Bookmark an other cool selfhosted project on github
  2. Go to your grimoire page and see the text overlapping where the favicon should be

Expected behavior
The favicon should show correctly

Screenshots
Screenshot from 2024-12-16 21-32-51

@goniszewski
Copy link
Owner

Hello @rllola! The text being displayed may be a fallback for the <img> tag. Can you post here how does the URL for it look?

@rllola
Copy link
Author

rllola commented Dec 21, 2024

Yeah sure.
So if you want to reproduce it you can try to add this other cool selfhosted project to your collection : https://github.com/jordan-dalby/ByteStash

As an icon it pickup this url : https://github.com/manifest.json

It should just pickup the github icon but is missing it.

EDIT: It actually does it for all the github repo I have bookmarked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants