Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't "go get" branches with capital letters in their name #1292

Closed
seeruk opened this issue Jun 28, 2019 · 0 comments · Fixed by #1298
Closed

Can't "go get" branches with capital letters in their name #1292

seeruk opened this issue Jun 28, 2019 · 0 comments · Fixed by #1298
Labels
bug Something isn't working

Comments

@seeruk
Copy link

seeruk commented Jun 28, 2019

Describe the bug
Attempting to go get a branch with capital letters in the name currently results in a HTTP 500. It appears that this is because Athens isn't decoding the branch name before using it. This is outlined in this issue in the golang/go repository.

Error Message
If applicable add error message to help explain your problem or console output enclose in triple back-ticks eg,

$ go get -u bitbucket.org/icelolly/<...>@ICE-163-<...>
go: finding bitbucket.org/icelolly/<...> ICE-163-<...>
go: finding bitbucket.org/icelolly ICE-163-<...>
go: finding bitbucket.org ICE-163-<...>
go get bitbucket.org/icelolly/<...>@ICE-163-<...>: unexpected status (http://athens.<...>/bitbucket.org/icelolly/<...>/@v/ICE-163-<...>.info): 500 Internal Server Error

(Side note here, this is the same thing that happens if the branch doesn't exist, the error could probably be more useful / obvious, like returning a 404 if the branch wasn't found. In this case, the branch definitely exists).

To Reproduce
Steps to reproduce the behavior:

  1. Create a branch on Go Modules based project that includes capital letters.
  2. Attempt to download that branch via go get.

Expected behavior
A clear and concise description of what you expected to happen.

It to successfully download the branch.

Environment (please complete the following information):

  • OS: Linux <...> 5.1.15-arch1-1-ARCH #1 SMP PREEMPT Tue Jun 25 04:49:39 UTC 2019 x86_64 GNU/Linux
  • Go version: go version go1.12.6 linux/amd64
  • Proxy version: 0.4.0 (I think, I'm using the Helm chart, version 0.2.11, but if you go to the version endpoint of Athens, that just reports "unset" as the version).
  • Storage: fs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants