From 9e2e5a1e72c9a10790057cbbdcbfbf42de5fc0f0 Mon Sep 17 00:00:00 2001
From: "Andrew S. Brown" <andrew@launchdarkly.com>
Date: Mon, 28 Dec 2020 10:42:21 -0800
Subject: [PATCH] Fix forbidigo linter name in reports

---
 pkg/golinters/forbidigo.go | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/pkg/golinters/forbidigo.go b/pkg/golinters/forbidigo.go
index 1b4dc7686d7a..41d036c8bc47 100644
--- a/pkg/golinters/forbidigo.go
+++ b/pkg/golinters/forbidigo.go
@@ -12,18 +12,17 @@ import (
 	"github.com/golangci/golangci-lint/pkg/result"
 )
 
-const forbidigoName = "forbidigo"
-
 func NewForbidigo() *goanalysis.Linter {
+	const linterName = "forbidigo"
 	var mu sync.Mutex
 	var resIssues []goanalysis.Issue
 
 	analyzer := &analysis.Analyzer{
-		Name: forbidigoName,
+		Name: linterName,
 		Doc:  goanalysis.TheOnlyanalyzerDoc,
 	}
 	return goanalysis.NewLinter(
-		forbidigoName,
+		linterName,
 		"Forbids identifiers",
 		[]*analysis.Analyzer{analyzer},
 		nil,
@@ -34,7 +33,7 @@ func NewForbidigo() *goanalysis.Linter {
 			var res []goanalysis.Issue
 			forbid, err := forbidigo.NewLinter(s.Forbid)
 			if err != nil {
-				return nil, errors.Wrapf(err, "failed to create linter %q", forbidigoName)
+				return nil, errors.Wrapf(err, "failed to create linter %q", linterName)
 			}
 
 			for _, file := range pass.Files {
@@ -46,7 +45,7 @@ func NewForbidigo() *goanalysis.Linter {
 					res = append(res, goanalysis.NewIssue(&result.Issue{
 						Pos:        hint.Position(),
 						Text:       hint.Details(),
-						FromLinter: makezeroName,
+						FromLinter: linterName,
 					}, pass))
 				}
 			}